On 6/8/25 1:23 AM, Oleg Tolmatcev wrote:
Am So., 8. Juni 2025 um 02:43 Uhr schrieb Pierrick Bouvier
<pierrick.bouv...@linaro.org>:

On 6/7/25 2:45 AM, oltolm wrote:
Sorry, I forgot to cc the maintainers.

The build failed when run on Windows. I replaced calls to Unix programs
like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to
´os.path.relpath´ in try-except because it can fail when the two paths
are on different drives. I made sure to convert the Windows paths to
Unix paths to prevent warnings in generated files.

Signed-off-by: oltolm <oleg.tolmat...@gmail.com>
---
   contrib/plugins/meson.build         |  2 +-
   plugins/meson.build                 |  2 +-
   scripts/tracetool/__init__.py       | 15 ++++++++++++---
   scripts/tracetool/backend/ftrace.py |  4 +---
   scripts/tracetool/backend/log.py    |  4 +---
   scripts/tracetool/backend/syslog.py |  4 +---
   tests/functional/meson.build        |  4 +---
   tests/include/meson.build           |  2 +-
   tests/tcg/plugins/meson.build       |  2 +-
   trace/meson.build                   |  5 +++--
   10 files changed, 23 insertions(+), 21 deletions(-)

Are you building using msys2, or another environment on Windows? I'm
curious to know in which configuration the build is failing.

In case you use msys2, maybe you're simply missing some packages. Our
documentation explains what to install [1].
Building out of msys2 on Windows is not recommended, as this is the only
maintained setup (tested in our CI, and maintained as an msys2 package
by msys2 maintainers) for this system.

[1] https://www.qemu.org/docs/master/devel/build-environment.html

Yes I do use msys2, but I only use bash for the initial configuration.
Afterwards I just call meson and ninja from "cmd" not from bash.

Maybe it's because it's complicated to execute a single command from msys2, and return. Using the -shell parameter of msys2_shell, you can pass arguments to bash.

cmd.exe /c c:/msys64/msys2_shell.cmd -defterm -here -no-start -mingw64
  -shell bash -c 'ls / /tmp'

That said, I'm not opposed to the current series, I just wanted to understand what is the context.

Thanks,
Pierrick

Reply via email to