On Tue, 18 Mar 2025 at 13:11, Corvin Köhne <[email protected]> wrote: > > From: YannickV <[email protected]> > > The CX7200 has one SD controller connected to address 0xE0101000. > The controller connected to address 0xE0100000 can be removed.
Hi -- I see Edgar has done some review on the first part of this patchset, but looking quickly over the second half I notice that it has quite a few commits like this that are removing/changing code that was just added in an earlier patch in the series. Please don't structure the patchset this way. If the board has only one SD controller, then send a patchset that puts in one SD controller, not one that puts in 2 and then removes 1 of them. Similarly for most of these other "remove" or "adjust" patches. (If you want to add a board in a way that breaks it down into smaller patches for easier review, one way to do this is that you start with a "skeleton" version of the board with e.g. just the CPU and one or two devices, and then in later patches you add more devices. But in this case the board code looks small enough that that's not necessary.) thanks -- PMM
