On 25/4/25 00:35, Pierrick Bouvier wrote:
On 4/24/25 15:20, Philippe Mathieu-Daudé wrote:
A machine defined with the DEFINE_MACHINE_ARM_AARCH64() macro
will be available on qemu-system-arm and qemu-system-aarch64
binaries.
One defined with DEFINE_MACHINE_AARCH64() will only be available
in the qemu-system-aarch64 binary.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
include/hw/arm/machines-qom.h | 13 +++++++++++++
target/arm/machine.c | 12 ++++++++++++
2 files changed, 25 insertions(+)
I won't block this change as we need to move on, but I still consider we
do a bad compromise between code readability/grepability, to avoid a
code size increase of +0.0005%.
I know, I'm just trying to keep moving while keeping everybody happy
(there was no further update on your v4 comments).
Anyway, we can always change that later when adding a second architecture.
I expect this to not change for (current) homogeneous machines.
Heterogeneous machines won't use these fixed arrays; there I
expect compound literals to be more useful.
Reviewed-by: Pierrick Bouvier <[email protected]>
Thanks!
