> > struct field names starting with an initial capital is
> > not the usual QEMU code style. Can this be all initial
> > lowercase, with capital just for word separation.
>
> I think Isaku used such names because they are defined in TDVF Design Guide
> spec[1].
>
> QEMU's internal data structure for metadata are below, which follows QEMU
> coding style.
>
> typedef struct TdxFirmwareEntry {
> uint32_t data_offset;
> uint32_t data_len;
> uint64_t address;
> uint64_t size;
> uint32_t type;
> uint32_t attributes;
> } TdxFirmwareEntry;
>
> typedef struct TdxFirmware {
> uint32_t nr_entries;
> TdxFirmwareEntry *entries;
> } TdxFirmware;
>
> So if no strong preference, I would keep it as-is that the raw struct read
> from TDVF keeps the name convention of TDVF Design Guide spec and internal
> data struct uses QEMU's convention.
>
> [1] https://cdrdv2.intel.com/v1/dl/getContent/733585
Or you can add a simple comemnt about "the raw struct read from TDVF
keeps the name convention of TDVF Design Guide spec", to remind other
people that there is no need to clean up the style here. I have no
objections; up to you.
