Re: [PATCH 12/17] target/avr: Handle offset_io in helper.c

[Pierrick Bouvier]

On 3/23/25 10:37, Richard Henderson wrote:

Prepare for offset_io being non-zero in do_stb.

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  target/avr/helper.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/avr/helper.c b/target/avr/helper.c
index 9608e59584..3323f32c22 100644
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -69,7 +69,8 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int 
interrupt_request)

static void do_stb(CPUAVRState *env, uint32_t addr, uint8_t data, uintptr_t ra)

  {
-    cpu_stb_mmuidx_ra(env, addr, data, MMU_DATA_IDX, ra);
+    cpu_stb_mmuidx_ra(env, addr + env_archcpu(env)->offset_io,
+                      data, MMU_DATA_IDX, ra);
  }

void avr_cpu_do_interrupt(CPUState *cs)

Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>