Re: [PATCH 07/13] target/arm/cpu: always define kvm related registers

[Philippe Mathieu-Daudé]

On 18/3/25 05:51, Pierrick Bouvier wrote:

This does not hurt, even if they are not used.

I'm not convinced by the rationale.

Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  target/arm/cpu.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 23c2293f7d1..96f7801a239 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -971,7 +971,6 @@ struct ArchCPU {
       */
      uint32_t kvm_target;

-#ifdef CONFIG_KVM

      /* KVM init features for this CPU */
      uint32_t kvm_init_features[7];

@@ -984,7 +983,6 @@ struct ArchCPU { /* KVM steal time */

      OnOffAuto kvm_steal_time;
-#endif /* CONFIG_KVM */

Maybe we need an opaque ArchAccelCpuState structure...

/* Uniprocessor system with MP extensions */

      bool mp_is_up;