Re: [PATCH 5/6] hw/ppc: Pass device tree properties for Fadump

[Aditya Gupta]

On 27/02/25 08:58, Nicholas Piggin wrote:

On Mon Feb 17, 2025 at 5:17 PM AEST, Aditya Gupta wrote:

<...snip...>
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index f3a4b4235d43..3602e5b5d18d 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -897,9 +897,27 @@ static int spapr_dt_rng(void *fdt)
  static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt)
  {

You might be able to add a spapr_dt_rtas_fadump() function
and do it there to help keep functions small?

Sure.


Thanks,

- Aditya G

Thanks,
Nick