Re: [PATCH v5 3/3] target/mips: Enable MSA ASE using a CLI flag

[Richard Henderson]

On 2/26/25 09:03, Aleksandar Rakic wrote:

--- a/target/mips/internal.h
+++ b/target/mips/internal.h
@@ -399,7 +399,7 @@ static inline void compute_hflags(CPUMIPSState *env)
          }
      }
      if (ase_msa_available(env)) {
-        if (env->CP0_Config5 & (1 << CP0C5_MSAEn)) {
+        if ((env->CP0_Config5 & (1 << CP0C5_MSAEn)) || (env->msa_on)) {
              env->hflags |= MIPS_HFLAG_MSA;
          }
      }

This is the wrong place to force-enable msa.
You should be enabling the bit in Config5 during cpu realize.


r~