From: Nicholas Piggin <[email protected]> Nothing should be doing this, but it doesn't get caught by pci_register_bar(). Add an assertion to prevent misuse.
Signed-off-by: Nicholas Piggin <[email protected]> Message-Id: <[email protected]> Reviewed-by: Phil Dennis-Jordan <[email protected]> Signed-off-by: Nicholas Piggin <[email protected]> Reviewed-by: Phil Dennis-Jordan <[email protected]> Reviewed-by: Akihiko Odaki <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> --- hw/pci/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 69a1b8c298..1d42847ef0 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1398,6 +1398,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, assert(hdr_type != PCI_HEADER_TYPE_BRIDGE || region_num < 2); r = &pci_dev->io_regions[region_num]; + assert(!r->size); r->addr = PCI_BAR_UNMAPPED; r->size = size; r->type = type; -- MST
