On 19.04.2012, at 21:25, Stefan Weil wrote: > Am 19.04.2012 16:47, schrieb Peter Maydell: >> On 19 April 2012 15:23, Alexander Graf <[email protected]> wrote: >>> On my PPC host, HOST_LONG_SIZE is not defined even after >>> running configure. Use the normal C way of determining the >>> long size instead. >>> #elif defined(HOST_PPC) >>> - return HOST_LONG_SIZE; >>> + return sizeof(long); >>> #else >> >> HOST_LONG_SIZE was removed by Stefan in commit 9c6ecf; >> it looks like this PPC-only use was accidentally omitted. >> For consistency with that commit and how we handle TYPE_LONG >> in this function, it would be better to use 'sizeof(void *)' >> here I think. >> >> -- PMM > > The patch which added this HOST_LONG_SIZE was written before > my patch which removed HOST_LONG_SIZE, but it was committed > to QEMU master _after_ my patch. > > As Peter wrote, sizeof(void *) would be a good replacement for > PPC(64) here.
Ok, changed to sizeof(void*). Since the patch is so trivial, I won't repost it, but instead just send it out with my next pull request. Alex
