On Wed, Jan 22, 2025 at 6:11 PM Jason Chien <jason.ch...@sifive.com> wrote: > > Ping > > Jason Chien <jason.ch...@sifive.com> 於 2025年1月15日 週三 下午10:17寫道: >> >> Initially, the IOMMU would create a thread, but this thread was removed in >> the merged version. The struct members for thread control should have been >> removed as well, but they were not removed in commit 0c54acb8243 >> ("hw/riscv: add RISC-V IOMMU base emulation"). >> >> Signed-off-by: Jason Chien <jason.ch...@sifive.com> >> Reviewed-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> >> Reviewed-by: Andrew Jones <ajo...@ventanamicro.com>
Please use a cover letter for multiple patches in the future: https://www.qemu.org/docs/master/devel/submitting-a-patch.html#include-a-meaningful-cover-letter Thanks! Applied to riscv-to-apply.next Alistair >> --- >> hw/riscv/riscv-iommu.h | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/hw/riscv/riscv-iommu.h b/hw/riscv/riscv-iommu.h >> index 9424989df4..fa8a50fa24 100644 >> --- a/hw/riscv/riscv-iommu.h >> +++ b/hw/riscv/riscv-iommu.h >> @@ -58,11 +58,6 @@ struct RISCVIOMMUState { >> /* interrupt notifier */ >> void (*notify)(RISCVIOMMUState *iommu, unsigned vector); >> >> - /* IOMMU State Machine */ >> - QemuThread core_proc; /* Background processing thread */ >> - QemuCond core_cond; /* Background processing wake up signal */ >> - unsigned core_exec; /* Processing thread execution actions */ >> - >> /* IOMMU target address space */ >> AddressSpace *target_as; >> MemoryRegion *target_mr; >> -- >> 2.43.2 >>