On 20 April 2012 18:01, Andreas Färber <[email protected]> wrote: > Am 14.04.2012 18:42, schrieb Peter Maydell: >> @@ -213,14 +207,17 @@ static void highbank_init(ram_addr_t ram_size, >> } >> >> for (n = 0; n < smp_cpus; n++) { >> + ARMCPU *cpu; >> env = cpu_init(cpu_model); >> if (!env) { >> fprintf(stderr, "Unable to find CPU definition\n"); >> exit(1); >> } >> + cpu = arm_env_get_cpu(env); > > Ugh, I'd like to avoid this creeping into boards... Would you mind > applying the updated 1-13 (they should all have some tag of mine now) > and rebasing this one on a patch that I'll send you shortly, changing > cpu_arm_init() signature?
Aren't boards going to need arm_env_get_cpu() anyway, since they need to get at a QOM object to set properties on? (I'm happy to leave this patch off if it's not fully baked yet. I'll put 1-13 in a pullreq tomorrow I think.) -- PMM
