On 25/11/24 20:56, Jean-Philippe Brucker wrote:
In order to write an event log, the ROM load notification handler needs
two more fields.

IMHO it makes more sense to squash that in the "hw/core/loader:
Add ROM loader notifier" patch introducing that API.


Signed-off-by: Jean-Philippe Brucker <jean-phili...@linaro.org>
---
v2->v3: New
---
  include/hw/loader.h | 2 ++
  hw/core/loader.c    | 2 ++
  2 files changed, 4 insertions(+)

diff --git a/include/hw/loader.h b/include/hw/loader.h
index 0cd9905f97..73f317966d 100644
--- a/include/hw/loader.h
+++ b/include/hw/loader.h
@@ -355,6 +355,8 @@ ssize_t rom_add_option(const char *file, int32_t bootindex);
typedef struct RomLoaderNotify {
      /* Parameters passed to rom_add_blob() */
+    const char *name;

Description of the loaded ROM.

+    uint8_t *data;

Or 'blob', blob_ptr. Maybe declare as 'const void *'?

      hwaddr addr;

Now easier to document, where 'data' is addressed in guest memory.

      size_t len;

Size of 'data'.

      size_t max_len;

Still unused. Drop?

Reply via email to