On Fri, Nov 22, 2024 at 11:40:42PM +0100, Kevin Wolf wrote: > pci_devfn properties accept both integer and string values, but > integer 1 and string '1' have different meanings: The integer value > means device 0, function 1 whereas the string value '1' is short for > '1.0' and means device 1, function 0. > > This test wants the string version so that the device actually becomes > visible for the guest. device_add hides the problem because it goes > through QemuOpts, which turns all properties into strings - this is a > QEMU bug that we want to fix, but that cancelled out the bug in this > test. > > Fix the test first so that device_add can be fixed afterwards. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > tests/avocado/hotplug_blk.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
