On Mon, Nov 04, 2024 at 02:32:53PM +0000, CLEMENT MATHIEU--DRIF wrote: > Hi everyone, > > It seems that https://github.com/Zeex/subhook (EDK2 submodule) is not > longer available on github (which makes recursive pull of submodules > fail for a lot of people). > Do you think we should do something on our side?
Once EDK2 fix the problem, then QEMU can update its EDK2 submodule to get the fix. It should not be a major problem meanwhile because there's no compelling reason for QEMU contributors to do a recursive checkout of all submodules. It'll only affect those with EDK2 checked out, which is not a common thing to need to do to start with, since we provide rebuilt EDK2. Our make-release script checks out EDK2 submodule, but does not do this recursively - it only pulls a couple of hand-picked sub-submodules, not including Zeex/subhook. If you know of any other scenarios that are a problem please say. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
