On Tue, Oct 22, 2024 at 11:49:46AM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Oct 22, 2024 at 12:23 AM Andrew Keesler <ankees...@google.com> > wrote: > > > Hi Marc-André - > > > > The ability to set the name with QMP qom-set seems like a nice behavior. > > > > Note that the ultimate goal of this name is to propagate it downstream to > > a device (see next patch[0] for a sample propagation to virtio-gpu). > > > > In order to accomplish this, would it work to expose this new "head_name" > > property via a qemu_graphic_console_get_head_name(QemuConsole *c) function > > that: > > > > 1. verifies that c is indeed a QemuGraphicConsole with > > QEMU_IS_GRAPHIC_CONSOLE(), and > > 2. returns c->head_name (similar to qemu_console_get_name() from [0])? > > > > > We'd probably need a similar function > > qemu_graphic_console_get_head_name(QemuConsole *c, const char *name) in > > order to > > set the head_name from a display (e.g., VNC) - correct me if you were > > thinking > > > > Right (qemu_graphic_console_set_head_name), get/set exposed to QOM via > object_class_property_add_str() > > > > of going a different direction with this interface, though. My main goal > > is to > > provide some way for a user to inject a display EDID name from the command > > line. > > > > Also, just to verify my understanding - there would never be a QemuConsole > > that > > a) is NOT a QemuGraphicConsole AND b) is associated with an EDID in a > > guest, > > correct? > > > > > Seems correct. > > (fwiw, I think we should have all UI info(s) as part of QemuUIInfo, > including the head name, but this would require further refactoring to > avoid some copy etc)
QemuUIInfo is an internal struct, on the public side we have DisplayOptions in QAPI which is where this should live. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
