On Wed, Oct 16, 2024 at 11:21:59AM -0400, Stefan Berger wrote: > Rather than waiting for the completion of migration on the source side, > wait for it on the destination QEMU side to avoid accessing the TPM TIS > memory mapped registers before QEMU could restore their state. This > error condition could be triggered on busy systems where the destination > QEMU did not have enough time to restore the TIS state while the test case > was already reading its registers. The test case was for example reading > the STS register and received an unexpected value (0xffffffff), which > lead to a segmentation fault later on due to trying to read 0xffff bytes > from the TIS into a buffer. > > Cc: qemu-sta...@nongnu.org > Reported-by: Fabiano Rosas <faro...@suse.de> > Signed-off-by: Stefan Berger <stef...@linux.ibm.com> > --- > tests/qtest/tpm-tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|