Re: [PATCH v3 0/6] Support GPIO for AST2700

[Cédric Le Goater]

Hello Jamin,

On 9/26/24 09:45, Jamin Lin wrote:

v1: Support GPIO for AST2700
v2: Fix clear incorrect interrupt status and adds reviewer suggestions
v3: remove nested conditionals and adds reviewer suggestions

Jamin Lin (6):
   hw/gpio/aspeed: Fix coding style
   hw/gpio/aspeed: Support to set the different memory size
   hw/gpio/aspeed: Support different memory region ops
   hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index
     mode
   hw/gpio/aspeed: Add AST2700 support
   aspeed/soc: Support GPIO for AST2700

  hw/arm/aspeed_ast27x0.c       |  18 +-
  hw/gpio/aspeed_gpio.c         | 427 ++++++++++++++++++++++++++++++++--
  include/hw/gpio/aspeed_gpio.h |   4 +-
  3 files changed, 430 insertions(+), 19 deletions(-)

Could you please to add tests in tests/qtest/aspeed_gpio-test.c
for this changes ? At least one with the ast2700-evb machine if
possible.


Thanks,

C.