On 2024/07/22 9:17, Michael S. Tsirkin wrote:
From: Akihiko Odaki <[email protected]>
A SR-IOV VF cannot have a ROM BAR.
Co-developed-by: Yui Washizu <[email protected]>
Signed-off-by: Akihiko Odaki <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
---
hw/pci/pci.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4c7be52951..bd956637bc 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2359,6 +2359,14 @@ static void pci_add_option_rom(PCIDevice *pdev, bool
is_default_rom,
return;
}
+ if (pci_is_vf(pdev)) {
+ if (pdev->rom_bar == ON_OFF_AUTO_ON) {
This requires:
https://lore.kernel.org/r/[email protected]
("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
However it does not seem included in this pull request.
Regards,
Akihiko Odaki