> > diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c > > index 20b70dcd81..174b490e5f 100644 > > --- a/hw/acpi/pci.c > > +++ b/hw/acpi/pci.c > > @@ -24,8 +24,12 @@ > > */ > > > > #include "qemu/osdep.h" > > +#include "qemu/error-report.h" > > > +#include "qapi/error.h" > is this necessary? > it seems to be compiling just fine without it. The error_fatal extern is in there.
I guess there is a non obvious path via which that's getting included anyway. is in there and it's not obvious how it is included I'd rather keep it as an explicit include to reduce fragility if the chain of includes involved gets changed. > > > +#include "hw/boards.h" > > #include "hw/acpi/aml-build.h" > > #include "hw/acpi/pci.h" > > +#include "hw/pci/pci_device.h" > > #include "hw/pci/pcie_host.h" > >
