On 03/27/2012 09:36 PM, Jia Liu wrote: >> > This patch should have been split as well, adding translations of the insns >> > at the same time you add the helpers. That said, the actual code looks ok. >> > > helpers can be grouped by MIPS DSP manual, BUT translations have to > grouped by opcode. > There is some difference between them, I'll try to do this. >
One possibility is to add the bare skeleton of the decoding by opcode first, leaving out the actual case statements. Then add the case OPCODE: gen_helper(); break; in the patch adding the helpers. r~