Nabih Estefan <[email protected]> writes: > There is an extra `buf=` set that is not used by npcm-gmac. Remove it > for coverity to be happy.
Have you go the coverity reference to include in the commit message? > > Signed-off-by: Nabih Estefan <[email protected]> > --- > hw/net/npcm_gmac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c > index 1b71e2526e..b397fd5064 100644 > --- a/hw/net/npcm_gmac.c > +++ b/hw/net/npcm_gmac.c > @@ -614,7 +614,6 @@ static void gmac_try_send_next_packet(NPCMGMACState *gmac) > net_checksum_calculate(tx_send_buffer, length, csum); > qemu_send_packet(qemu_get_queue(gmac->nic), tx_send_buffer, > length); > trace_npcm_gmac_packet_sent(DEVICE(gmac)->canonical_path, > length); > - buf = tx_send_buffer; So coverity is saying that buf starts at tx_send_buffer and none of the other legs that can mess with it are possible for the tx_desc.tdes1 & TX_DESC_TDES1_LAST_SEG_MASK leg? Or that buf should always start at tx_send_buffer and only ever advance if we grow the size of the tx_send_buffer? > length = 0; > } -- Alex Bennée Virtualisation Tech Lead @ Linaro
