Re: [PATCH 3/3] exec: use char* for pointer arithmetic

[Richard Henderson]

On 6/18/24 15:46, Roman Kiryanov wrote:

@@ -2839,7 +2839,7 @@ static inline uint8_t 
address_space_ldub_cached(MemoryRegionCache *cache,
  {
      assert(addr < cache->len);
      if (likely(cache->ptr)) {
-        return ldub_p(cache->ptr + addr);
+        return ldub_p((char*)cache->ptr + addr);

We require "char *" with a space.

With all of those fixed,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~


PS: I'm annoyed that standards never adopted arithmetic on void *.