On Tue, Jun 18, 2024 at 02:19:25PM -0700, Nicolin Chen wrote:
> On Tue, Jun 18, 2024 at 05:14:32PM -0400, Michael S. Tsirkin wrote:
> > > @@ -306,8 +314,8 @@ build_iort(GArray *table_data, BIOSLinker *linker,
> > > VirtMachineState *vms)
> > > }
> > >
> > > /* Append the last RC -> ITS ID mapping */
> > > - if (next_range.input_base < 0xFFFF) {
> > > - next_range.id_count = 0xFFFF - next_range.input_base;
> > > + if (next_range.input_base < 0x10000) {
> > > + next_range.id_count = 0x10000 - next_range.input_base;
> > > g_array_append_val(its_idmaps, next_range);
> > > }
> >
> > A change of logic here - I think the new one is right and old
> > one was wrong, actually. Right?
>
> Sorry, I don't quite follow that question...
>
> Doesn't a patch correct an old wrong one to a new right one?
>
> Thanks
> Nicolin
So if base is 0xFFFF what should happen? I think previously we
skipped an entry and that is wrong. So that's another latent
bug this patch fixes then?
Worth documenting in the commit log too.
--
MST
