Re: [PATCH 06/26] hw/ppc: Avoid using Monitor in xive_end_queue_pic_print_info()

[Harsh Prateek Bora]

On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:

@@ -1389,8 +1392,10 @@ void xive_end_pic_print_info(XiveEND *end, uint32_t 
end_idx, Monitor *mon)
      if (qaddr_base) {
          monitor_printf(mon, " eq:@%08"PRIx64"% 6d/%5d ^%d",
                         qaddr_base, qindex, qentries, qgen);
-        xive_end_queue_pic_print_info(end, 6, mon);
+        xive_end_queue_pic_print_info(end, 6, buf);
      }
+    info = human_readable_text_from_str(buf);
+    monitor_puts(mon, info->human_readable_text);
      monitor_printf(mon, "\n");

This monitor_printf could also be folded in buf before info assignment ?

  }