> -----Original Message----- > From: David Hildenbrand [mailto:[email protected]] > Sent: Tuesday, June 4, 2024 10:02 PM > To: Gonglei (Arei) <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; zhengchuan <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Xiexiangyou > <[email protected]>; [email protected]; lixiao (H) > <[email protected]>; [email protected]; Wangjialin > <[email protected]> > Subject: Re: [PATCH 1/6] migration: remove RDMA live migration temporarily > > On 04.06.24 14:14, Gonglei via wrote: > > From: Jialin Wang <[email protected]> > > > > The new RDMA live migration will be introduced in the upcoming few > > commits. > > > > Signed-off-by: Jialin Wang <[email protected]> > > Signed-off-by: Gonglei <[email protected]> > > --- > > [...] > > > - > > - /* Avoid ram_block_discard_disable(), cannot change during migration. > */ > > - if (ram_block_discard_is_required()) { > > - error_setg(errp, "RDMA: cannot disable RAM discard"); > > - return; > > - } > > I'm particularly interested in the interaction with virtio-balloon/virtio-mem. > > Do we still have to disable discarding of RAM, and where would you do that in > the rewrite? >
Yes, we do. We didn't change the logic. Thanks for your catching. Regards, -Gonglei > -- > Cheers, > > David / dhildenb
