On 15/05/2024 15:36, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/15/24 14:29, Avihai Horon wrote:
On 15/05/2024 15:25, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/15/24 14:17, Avihai Horon wrote:
On 13/05/2024 19:27, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 5/13/24 15:03, Avihai Horon wrote:
Hi Cedric,
On 06/05/2024 12:20, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO. Add documentation while at it.
First of all, I think commit 3688fec8923 ("memory: Add Error**
argument to .log_global_start() handler") forgot to set errp in
vfio_listener_log_global_start() in case of error.
yes. This is unfortunate. There has been a few respins, the series
was split and I was hoping to upstream this part sooner. My bad.
This causes a null pointer de-reference if DPT start fails.
Maybe add a fix for that in the beginning of this series, or as a
stand-alone fix?
Since it is fixed by patch 1+2 of this series, we should be fine ?
A fix could be useful to be backported to QEMU 9.0, no?
These changes were only merged in 9.1 with the migration PR.
Am I missing something ?
Oh, my bad. I thought they were merged in 9.0.
So patches 1+2 should cover it.
yeah. I still would like to merge them asap, with your little series
possibly, the one adding the event, plus the 2 cleanup series from
ZhenZhong. I will update vfio-next when they are sufficiently reviewed.
Sure, I am going to post v3 of my series shortly and then review your v6.
