RE: [PATCH v4 04/19] vfio/iommufd: Introduce TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO device

[Duan, Zhenzhong]

>-----Original Message-----
>From: Cédric Le Goater <c...@redhat.com>
>Subject: Re: [PATCH v4 04/19] vfio/iommufd: Introduce
>TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO device
>
>On 5/7/24 11:20, Zhenzhong Duan wrote:
>> TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO represents a host IOMMU
>device under
>> VFIO iommufd backend. It will be created during VFIO device attaching
>> and passed to vIOMMU.
>>
>> It will have its own .realize() implementation.
>>
>> Suggested-by: Cédric Le Goater <c...@redhat.com>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>
>> ---
>>   include/hw/vfio/vfio-common.h | 3 +++
>>   hw/vfio/iommufd.c             | 5 ++++-
>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-
>common.h
>> index 05a199ce65..affb73f209 100644
>> --- a/include/hw/vfio/vfio-common.h
>> +++ b/include/hw/vfio/vfio-common.h
>> @@ -32,6 +32,7 @@
>>   #include "sysemu/sysemu.h"
>>   #include "hw/vfio/vfio-container-base.h"
>>   #include "sysemu/host_iommu_device.h"
>> +#include "sysemu/iommufd.h"
>
>I don't think you need this include.

Yes, maybe not now. TYPE_HOST_IOMMU_DEVICE_IOMMUFD is needed:

#define TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO \
            TYPE_HOST_IOMMU_DEVICE_IOMMUFD "-vfio"

it can be replaced with:

#define TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO \
            TYPE_HOST_IOMMU_DEVICE "-iommufd-vfio"


But the main usage is in nesting series.
Below structure references HostIOMMUDeviceIOMMUFD which is in sysemu/iommufd.h

struct HostIOMMUDeviceIOMMUFDVFIO {
    HostIOMMUDeviceIOMMUFD parent_obj;

    VFIODevice *vdev;
};

Thanks
Zhenzhong