Re: [PATCH 14/14] accel/tcg: Access tcg_cflags with getter / setter

[Richard Henderson]

On 4/27/24 08:57, Philippe Mathieu-Daudé wrote:

Access the CPUState::tcg_cflags via tcg_cflags_has() and
tcg_cflags_set() helpers.

Mechanical change using the following Coccinelle spatch script:

   @@
   expression cpu;
   expression flags;
   @@
   -     cpu->tcg_cflags & flags
   +     tcg_cflags_has(cpu, flags)

   @@
   expression cpu;
   expression flags;
   @@
   -     (tcg_cflags_has(cpu, flags))
   +     tcg_cflags_has(cpu, flags)

   @@
   expression cpu;
   expression flags;
   @@
   -     cpu->tcg_cflags |= flags;
   +     tcg_cflags_set(cpu, flags);

Then manually moving the declarations, and adding both
tcg_cflags_has() and tcg_cflags_set() definitions.

Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org>
---

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~