On 23/4/24 07:05, CLEMENT MATHIEU--DRIF wrote:

On 22/04/2024 19:03, Philippe Mathieu-Daudé wrote:
On 22/4/24 17:52, CLEMENT MATHIEU--DRIF wrote:
The 'level' field in vtd_iotlb_key is an uint8_t.
We don't need to store level as an int in vtd_lookup_iotlb

Signed-off-by: Clément Mathieu--Drif <[email protected]>
---
   hw/i386/intel_iommu.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 6f1364b3fd..ba545590b1 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -333,7 +333,7 @@ static VTDIOTLBEntry
*vtd_lookup_iotlb(IntelIOMMUState *s, uint16_t source_id,
   {
       struct vtd_iotlb_key key;
       VTDIOTLBEntry *entry;
-    int level;
+    uint8_t level;

Or simply 'unsigned' up to vtd_slpt_level_shift()?
vtd_iotlb_key.level is an uint8_t, just avoiding a warning here

What warning?

Reply via email to