Re: [PATCH v5 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

[Jonathan Cameron via]

> > > +static void cxl_destroy_dc_regions(CXLType3Dev *ct3d)
> > > +{
> > > +    CXLDCExtent *ent;
> > > +
> > > +    while (!QTAILQ_EMPTY(&ct3d->dc.extents)) {
> > > +        ent = QTAILQ_FIRST(&ct3d->dc.extents);
> > > +        cxl_remove_extent_from_extent_list(&ct3d->dc.extents, ent);  
> > 
> > Isn't this same a something like.
> >     QTAILQ_FOREACH_SAFE(ent, &ct3d->dc.extents, node)) {
> >     cxl_remove_extent_from_extent_list(&ct3d->dc.extents, ent);
> >         //This wrapper is small enough I'd be tempted to just have the
> >         //code inline at the places it's called.
> >   
> We will have more to release after we introduce pending list as well as
> bitmap. Keep it?
ok. 
> 
> Fan
> 
> >     }  
> > > +    }
> > > +}  
> >