On 28.02.24 19:37, Zhao Liu wrote:
From: Zhao Liu<[email protected]>As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend(), error_vprepend() or * error_append_hint(), because that doesn't work with &error_fatal. * ERRP_GUARD() lifts these restrictions. * * To use ERRP_GUARD(), add it right at the beginning of the function. * @errp can then be used without worrying about the argument being * NULL or &error_fatal. ERRP_GUARD() could avoid the case when @errp is the pointer of error_fatal, the user can't see this additional information, because exit() happens in error_setg earlier than information is added [1]. The cbw_open() passes @errp to error_prepend() without ERRP_GUARD(). Though it is the BlockDriver.bdrv_open() method, and currently its @errp parameter only points to callers' local_err, to follow the requirement of @errp, add missing ERRP_GUARD() at the beginning of this function. [1]: Issue description in the commit message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: John Snow<[email protected]> Cc: Vladimir Sementsov-Ogievskiy<[email protected]> Cc: Kevin Wolf<[email protected]> Cc: Hanna Reitz<[email protected]> Signed-off-by: Zhao Liu<[email protected]>
Your actual email is at linux.intel.com, is it all OK? I'd prefer not to abbreviate copy-before-write in subject, but anyway: Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Thanks for fixing! -- Best regards, Vladimir
