> > > > + if (smp_cache_string_to_topology(ms, config->l1d_cache,
> > > > + &ms->smp_cache.l1d, errp)) {
> > >
> > > Indent is to wrong opening bracket.
> > > Same for other cases.
> >
> > Could you please educate me about the correct style here?
> > I'm unsure if it should be indented by 4 spaces.
>
> It needs to look like this:
>
> if (smp_cache_string_to_topology(ms, config->l1d_cache,
> &ms->smp_cache.l1d, errp)) {
>
> so func parameters are aligned to the function calls' opening bracket,
> not the 'if' statement's opening bracket.
>
Thanks for your explaination!
Regards,
Zhao
