> -----Original Message----- > From: [email protected] <qemu-block- > [email protected]> On Behalf Of Akihiko Odaki > Sent: Monday, February 12, 2024 7:21 PM > To: Philippe Mathieu-Daudé <[email protected]>; Michael S. Tsirkin > <[email protected]>; Marcel Apfelbaum <[email protected]>; Alex > Williamson <[email protected]>; Cédric Le Goater <[email protected]>; > Paolo Bonzini <[email protected]>; Daniel P. Berrangé <[email protected]>; > Eduardo Habkost <[email protected]>; Sriram Yagnaraman > <[email protected]>; Jason Wang <[email protected]>; Keith Busch > <[email protected]>; Klaus Jensen <[email protected]> > Cc: [email protected]; [email protected]; Akihiko Odaki > <[email protected]> > Subject: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances > > Disable SR-IOV VF devices by reusing code to power down PCI devices > instead of removing them when the guest requests to disable VFs. This > allows to realize devices and report VF realization errors at PF > realization time. > > Signed-off-by: Akihiko Odaki <[email protected]>
Hello Akihiko, I think this patch fixes the issue reported in [1]. The latest master branch also causes an object-related assertion error when we enable VF(s) and disable through sysfs over and over again (at least twice). But this issue is also fixed with your patch. ** ERROR:../qom/object.c:753:object_finalize: assertion failed: (obj->parent == NULL) Bail out! ERROR:../qom/object.c:753:object_finalize: assertion failed: (obj->parent == NULL) Klaus, If this patchset is applied, I think [1] can be dropped. What do you think? Thanks, [1] https://lore.kernel.org/qemu-devel/20240109022953epcms2p54550dcfc9f831a515206513ae98e7511@epcms2p5/
