Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

[Amos Kong]

On 14/03/12 15:27, Paolo Bonzini wrote:

Hi Paolo,

Il 14/03/2012 08:14, Orit Wasserman ha scritto:

if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))<  0)
{       
     closesocket(*fd);
     return -socket_error();
}
return 0;

and than you will not need ret

But closesocket could clobber socket_error(), no?

Yes, it will effect socket_error()

How about this fix ?

    ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
    if (ret < 0) {
        ret = -socket_error();
        closesocket(*fd);
    }
    return ret;
}

--
                        Amos.