On 2024/1/31 13:06, Richard Henderson wrote:
On 1/30/24 21:11, LIU Zhiwei wrote:+/* This stub just works for making vendors array not empty */ +riscv_csr_operations stub_csr_ops[CSR_TABLE_SIZE]; +static inline bool never_p(const RISCVCPUConfig *cfg) +{ + return false; +} + +void riscv_tcg_cpu_register_vendor_csr(RISCVCPU *cpu) +{ + static const struct { + bool (*guard_func)(const RISCVCPUConfig *); + riscv_csr_operations *csr_ops; + } vendors[] = { + { never_p, stub_csr_ops }, + }; + for (size_t i = 0; i < ARRAY_SIZE(vendors); ++i) {Presumably you did this to avoid a Werror for "i < 0", since i is unsigned.
Yes. That's the gcc complains.
It would be better to either use "int i"
OK
, or for (size_t i = 0, n = ARRAY_SIZE(vendors); i < n; ++i) either of which will not Werror.
This works. I don't know why it works, because n is 0 and never changes.
Especially considering the size of stub_csr_ops.
Do you mean we should remove the stub_csr_ops? I don't know how to relate your two solving ways to stub_csr_ops.
Thanks, Zhiwei
r~
