On Tue, Jan 30, 2024 at 12:20:01PM +0000, Richard W.M. Jones wrote:
> With GCC 14 the code failed to compile on i686 (and was wrong for any
> version of GCC):
>
> ../block/blkio.c: In function ‘blkio_file_open’:
> ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from
> incompatible pointer type [-Wincompatible-pointer-types]
> 857 | &s->mem_region_alignment);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | size_t * {aka unsigned int *}
> In file included from ../block/blkio.c:12:
> /usr/include/blkio.h:49:67: note: expected ‘uint64_t *’ {aka ‘long long
> unsigned int *’} but argument is of type ‘size_t *’ {aka ‘unsigned int *’}
> 49 | int blkio_get_uint64(struct blkio *b, const char *name, uint64_t
> *value);
> |
> ~~~~~~~~~~^~~~~
>
> Signed-off-by: Richard W.M. Jones <[email protected]>
> ---
> block/blkio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)Thanks, applied to my block tree: https://gitlab.com/stefanha/qemu/commits/block Stefan
signature.asc
Description: PGP signature
