On 1/17/24 02:56, Peter Maydell wrote:
In arm_deliver_fault() we check for whether the fault is caused by a data abort due to an access to a FEAT_NV2 sysreg in the memory pointed to by the VNCR. Unfortunately part of the condition checks the wrong argument to the function, meaning that it would spuriously trigger, resulting in some instruction aborts being taken to the wrong EL and reported incorrectly.Use the right variable in the condition. Fixes: 674e5345275d425 ("target/arm: Report VNCR_EL2 based faults correctly") Reported-by: Jonathan Cameron<[email protected]> Signed-off-by: Peter Maydell<[email protected]> --- In less lax languages the compiler might have pointed out that the type of the LHS and the RHS in the comparison didn't match :-) --- target/arm/tcg/tlb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <[email protected]> r~
