On 03/12/12 16:50, Alon Levy wrote: > On Mon, Mar 12, 2012 at 01:43:11PM +0200, Alon Levy wrote: >> On Mon, Mar 12, 2012 at 11:20:55AM +0100, Gerd Hoffmann wrote: >>> On 03/11/12 20:26, Alon Levy wrote: >>>> dprint is still used for qxl_init_common one time prints. >>> >>> I think we shouldn't simply convert the dprintf's into trace-points. >>> >>> We should look at each dprintf and check whenever it makes sense at all, >>> whenever it makes sense at that place before converting it over to a >>> tracepoint. > > I'll also add qxl_spice_* trace points for the next patch. Does that > sound excessive? you could just trace the qxl_io_write to get the io > itself, or trace just qxl_spice_* to get the qxl<->spice interface, or > both (qxl_*).
Makes sense to place trace points systematically like that. cheers, Gerd
