On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote:
> It's more appropriate to set the maximum value into a fitting integer.
> ---
> audio/audio.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index bd9237e..06c2384 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -110,8 +110,8 @@ const struct mixeng_volume nominal_volume = {
> .r = 1.0,
> .l = 1.0,
> #else
> - .r = 1ULL << 32,
> - .l = 1ULL << 32,
> + .r = UINT_MAX,
> + .l = UINT_MAX,
> #endif
> };
How's putting UINT_MAX into int64_t more appropriate? UINT_MAX is
even one less than one in 32.32 fixpoint... I must be missing something
here.
--
mailto:[email protected]
