Hi Peter, On Mon, Jan 15, 2024 at 10:41:48AM +0000, Peter Maydell wrote: > Date: Mon, 15 Jan 2024 10:41:48 +0000 > From: Peter Maydell <[email protected]> > Subject: Re: [PATCH 02/11] hw/core: Cleanup unused included headers in > cpu-common.c > > On Mon, 15 Jan 2024 at 09:37, Zhao Liu <[email protected]> wrote: > > > > From: Zhao Liu <[email protected]> > > > > Remove unused headers in cpu-common.c: > > * qemu/notify.h > > * qemu/log.h > > * qemu/main-loop.h > > * exec/cpu-common.h > > * qemu/error-report.h > > * qemu/qemu-print.h > > > > Though hw/core/cpu.h has been included by sysemu/hw_accel.h, to keep > > the dependency clear, still directly include hw/core/cpu.h in this file. > > > > Tested by "./configure" and then "make". > > > > Signed-off-by: Zhao Liu <[email protected]> > > --- > > hw/core/cpu-common.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > Something seems to be wrong with your analysis of what > includes it is OK to drop. For instance, this file uses > the function qemu_log(), which is why it includes > qemu/log.h. >
I'm not sure about this, since qemu/log.h has been included by exec/log.h, so could we just include exec/log.h and omit qemu/log.h in this file? It seems enough for the compilation to omit qemu/log.h and only include exec/log.h. Regards, Zhao
