Hi Markus On Thu, Jan 11, 2024 at 4:36 PM Markus Armbruster <[email protected]> wrote: > > Any takers? >
I have it in my "dump" queue, but it's the only patch I got so far (I could have missed others). If it can go through my other means, that's fine with me > Markus Armbruster <[email protected]> writes: > > > -z without -R has no effect: the dump format remains @elf. Fix the > > logic error so it becomes @kdump-zlib. > > > > Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) > > Fixes: CID 1523841 > > Signed-off-by: Markus Armbruster <[email protected]> > > Reviewed-by: Stephen Brennan <[email protected]> > > Reviewed-by: Marc-André Lureau <[email protected]> > > --- > > dump/dump-hmp-cmds.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c > > index b428ec33df..d9340427c3 100644 > > --- a/dump/dump-hmp-cmds.c > > +++ b/dump/dump-hmp-cmds.c > > @@ -41,7 +41,7 @@ void hmp_dump_guest_memory(Monitor *mon, const QDict > > *qdict) > > dump_format = DUMP_GUEST_MEMORY_FORMAT_WIN_DMP; > > } > > > > - if (zlib && raw) { > > + if (zlib) { > > if (raw) { > > dump_format = DUMP_GUEST_MEMORY_FORMAT_KDUMP_RAW_ZLIB; > > } else { > > -- Marc-André Lureau
