Hi Xiaoyao,
On Thu, Jan 11, 2024 at 01:53:53PM +0800, Xiaoyao Li wrote:
> > - cores_per_pkg = topo_info.cores_per_die * topo_info.dies_per_pkg;
> > + cores_per_pkg = topo_info.cores_per_module * topo_info.modules_per_die
> > *
> > + topo_info.dies_per_pkg;
>
> Nit. maybe we can introduce some helper function like
>
> static inline uint32_t topo_info_cores_per_pkg(X86CPUTopoInfo *topo_info) {
> return topo_info.cores_per_module * topo_info.modules_per_die *
> topo_info.dies_per_pkg;
> }
>
> so we don't need to care how it calculates.
Yeah, will add this helper, maybe in another patch.
>
> Besides,
>
> Reviewed-by: Xiaoyao Li <[email protected]>
Thanks!
-Zhao
