Hi Gavin, On 15/11/23 00:55, Gavin Shan wrote:
There are two places where the user specified CPU type is checked to see if it's supported or allowed by the board: machine_run_board_init() and mc->init(). We don't have to maintain two duplicate sets of logic. This series intends to move the check to machine_run_board_init() so that we have unified CPU type check.PATCH[01-04] consolidate CPUClass::class_by_name() so that the returned CPU class is checked for once in cpu_class_by_name() PATCH[05] add generic helper cpu_model_from_type() to extract the CPU model name from the CPU type name PATCH[06] add generic cpu_list(), to be reused by most of the targets PATCH[07-21] switch to generic cpu_list() for most of the targets PATCH[22] use generic helper cpu_model_from_type() for several targets PATCH[23-31] validate the CPU type in machine_run_board_init() for the individual board v1: https://lists.nongnu.org/archive/html/qemu-arm/2023-07/msg00302.html v2: https://lists.nongnu.org/archive/html/qemu-arm/2023-07/msg00528.html v3: https://lists.nongnu.org/archive/html/qemu-arm/2023-09/msg00157.html v4: https://lists.nongnu.org/archive/html/qemu-arm/2023-11/msg00005.html
Maybe I missed the comment in earlier series, but what is the plan for the following targets? $ git grep 'define cpu_list' target/i386/cpu.h:2289:#define cpu_list x86_cpu_list target/ppc/cpu.h:1623:#define cpu_list ppc_cpu_list target/s390x/cpu.h:922:#define cpu_list s390_cpu_list target/sparc/cpu.h:673:#define cpu_list sparc_cpu_list Thanks, Phil.
