-----Original Message----- From: Peter Maydell <[email protected]> Sent: Tuesday, November 14, 2023 6:58 PM To: CS20 KFTing <[email protected]> Cc: Nabih Estefan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; IS20 Avi Fishman <[email protected]>; CS20 KWLiu <[email protected]>; IS20 Tomer Maimon <[email protected]>; IN20 Hila Miranda-Kuzi <[email protected]> Subject: Re: [PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox
On Tue, 14 Nov 2023 at 01:24, [email protected] <[email protected]> wrote: > > > > -----Original Message----- > From: Nabih Estefan <[email protected]> > Sent: Saturday, October 28, 2023 1:55 AM > To: [email protected] > Cc: [email protected]; [email protected]; CS20 KFTing > <[email protected]>; [email protected]; [email protected]; IS20 > Avi Fishman <[email protected]>; [email protected]; CS20 > KWLiu <[email protected]>; IS20 Tomer Maimon > <[email protected]>; IN20 Hila Miranda-Kuzi > <[email protected]> > Subject: [PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox > > CAUTION - External Email: Do not click links or open attachments unless you > acknowledge the sender and content. > > > From: Hao Wu <[email protected]> > > This patches adds a qtest for NPCM7XX PCI Mailbox module. > It sends read and write requests to the module, and verifies that the module > contains the correct data after the requests. > > Change-Id: Id7a4b3cbea564383b94d507552dfd16f6b5127d1 > Signed-off-by: Hao Wu <[email protected]> > Signed-off-by: Nabih Estefan <[email protected]> > --- > Signed-off-by: Tyrone Ting <[email protected]> Hi; can you clarify what you mean with this Signed-off-by: tag? Generally we use those where either you're the author of the code or else when you're taking somebody else's patch and including it in work you are sending to the list, and it doesn't seem like either of those are the case here. thanks -- PMM Hi: Thank you for your comments. In the email thread " [PATCH v4 00/11] Implementation of NPI Mailbox and GMAC Networking Module", it says " Hi; I'm afraid this is going to miss the 8.2 release, because it is still missing any review from Google or Nuvoton people." Is it okay to post "Acked by:" or "Reviewed by:" by someone from Nuvoton? Thank you. Regards, Tyrone ________________________________ ________________________________ The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
