Re: [PATCH-for-8.2 v4 04/10] hw/char/pl011: Extract pl011_write_txdata() from pl011_write()

[Richard Henderson]

On 11/9/23 11:28, Philippe Mathieu-Daudé wrote:

When implementing FIFO, this code will become more complex.
Start by factoring it out to a new pl011_write_txdata() function.
No functional change intended.

...

@@ -262,19 +273,13 @@ static void pl011_write(void *opaque, hwaddr offset,
                          uint64_t value, unsigned size)
  {
      PL011State *s = (PL011State *)opaque;
-    unsigned char ch;

trace_pl011_write(offset, value, pl011_regname(offset)); switch (offset >> 2) {

      case 0: /* UARTDR */
-        /* ??? Check if transmitter is enabled.  */
-        ch = value;
-        /* XXX this blocks entire thread. Rewrite to use
-         * qemu_chr_fe_write and background I/O callbacks */
-        qemu_chr_fe_write_all(&s->chr, &ch, 1);
-        s->int_level |= INT_TX;
-        pl011_update(s);
+        s->readbuff = value;

Why the write to readbuff?


r~