Re: [PATCH] dump:Add close fd on error return to avoid resource leak

[Philippe Mathieu-Daudé]

On 7/11/23 03:44, Zongmin Zhou wrote:

Signed-off-by: Zongmin Zhou<zhouzong...@kylinos.cn>

Reported-by: Coverity CID 1523842 (RESOURCE_LEAK)
Fixes: e6549197f7 ("dump: Add command interface for kdump-raw formats")
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

---
  dump/dump.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/dump/dump.c b/dump/dump.c
index 1c304cadfd..ad5294e853 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -2160,6 +2160,7 @@ void qmp_dump_guest_memory(bool paging, const char 
*protocol,
          return;
      }
      if (kdump_raw && lseek(fd, 0, SEEK_CUR) == (off_t) -1) {
+        close(fd);
          error_setg(errp, "kdump-raw formats require a seekable file");
          return;
      }