RE: [PATCH v6 13/21] virtio-net: Always set populate_hash

Mon, 30 Oct 2023 12:03:28 -0700 


> -----Original Message-----
> From: [email protected] <qemu-
> [email protected]> On Behalf Of Akihiko
> Odaki
> Sent: Monday, October 30, 2023 1:13 PM
> Cc: [email protected]; Yuri Benditovich
> <[email protected]>; Andrew Melnychenko
> <[email protected]>; Michael S . Tsirkin <[email protected]>; Jason Wang
> <[email protected]>; Akihiko Odaki <[email protected]>
> Subject: [PATCH v6 13/21] virtio-net: Always set populate_hash
> 
> The member is not cleared during reset so may have a stale value.
> 

/docs/devel/ebpf_rss.rst:
populate_hash - for now, not used. eBPF RSS doesn't support hash reporting.

We need update docs?
And why not clear it in virtio_net_reset function?

Thanks
Chen

> Signed-off-by: Akihiko Odaki <[email protected]>
> ---
>  hw/net/virtio-net.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index
> 1fa020d905..0fe75b3c08 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -650,6 +650,7 @@ static void virtio_net_set_mrg_rx_bufs(VirtIONet *n,
> int mergeable_rx_bufs,
>          n->guest_hdr_len = n->mergeable_rx_bufs ?
>              sizeof(struct virtio_net_hdr_mrg_rxbuf) :
>              sizeof(struct virtio_net_hdr);
> +        n->rss_data.populate_hash = false;
>      }
> 
>      for (i = 0; i < n->max_queue_pairs; i++) {
> --
> 2.42.0
> 

























					Reply via email to