On Wed, 18 Oct 2023 at 19:13, Nabih Estefan <[email protected]> wrote: > > From: Nabih Estefan Diaz <[email protected]> > > [Changes since v3] > Fixed comments from Hao Wu ([email protected]) > > [Changes since v2] > Fixed bugs related to the RC functionality of the GMAC. Added and > squashed patches related to that. > [Changes since v1] > Fixed some errors in formatting. > Fixed a merge error that I didn't see in v1. > Removed Nuvoton 8xx references since that is a separate patch set. > > [Original Cover] > Creates NPI Mailbox Module with data verification for read and write > (internal and external), > wiring to the Nuvoton SoC, and QTests. > > Also creates the GMAC Networking Module. Implements read and write > functionalities with cooresponding descriptors > and registers. Also includes QTests for the different functionalities. > > Hao Wu (5): > hw/misc: Add Nuvoton's PCI Mailbox Module > hw/arm: Add PCI mailbox module to Nuvoton SoC > hw/misc: Add qtest for NPCM7xx PCI Mailbox > hw/net: Add NPCMXXX GMAC device > hw/arm: Add GMAC devices to NPCM7XX SoC > > Nabih Estefan Diaz (6): > tests/qtest: Creating qtest for GMAC Module > include/hw/net: Implemented Classes and Masks for GMAC Descriptors > hw/net: General GMAC Implementation > hw/net: GMAC Rx Implementation > hw/net: GMAC Tx Implementation > tests/qtest: Adding PCS Module test to GMAC Qtest
Hi; I'm afraid this is going to miss the 8.2 release, because it is still missing any review from Google or Nuvoton people. PS: your patch 4 commit message seems to have got mangled somehow -- it appears to be multiple commit messages that have got concatenated. Was this intended to be more than one patch ? Also, for patches 1-5 which are by Hao Wu, you should add your Signed-off-by: after theirs, to indicate that their patch has come to QEMU via you. thanks -- PMM
