On 18/12/18 17:55, Philippe Mathieu-Daudé wrote: >> strpadcpy will instead just silence the warning. > migration/global_state.c:109:15: error: 'strlen' argument 1 declared > attribute 'nonstring' [-Werror=stringop-overflow=] > s->size = strlen((char *)s->runstate) + 1; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > GCC won... It is true this strlen() is buggy, indeed s->runstate might > be not NUL-terminated.
No, runstate is declared as an array of 100 bytes, which are more than enough. It's ugly code but not buggy. Paolo
